Closed seidewitz closed 5 months ago
@himi I don't think this one will affect visualization. However, let me know if you would like to review it.
I think so. The visualizer currently uses owned redefinitions only. I can check it for sure with some tricky examples. But if you'd like to complete it quickly, please do so without my review.
@himi There will also be another PR soon resolving ST6RI-720 (Remove automatic insertion of explicit subject and objective features), which might actually have a bigger impact. Perhaps you could just review that change, which will be in addition to the changes from this PR.
@seidewitz, thank you for letting me know about it. I'll do so. This PR itself looks quite reasonable because SysML/KerML parameters are positional as you previously said.
@himi FYI, it turns out I will not be creating a PR for ST6RI-720 after all. Implementation for this issue (which has been pushed to the ST6RI-720 branch) has identified additional considerations on the semantics of redefinition that will likely need to be addressed by the FTF(s).
FeatureAdapter::isComputeRedefinitions
so that implicit redefinitions are added even if aFeature
already hasownedRedefinitions
, consistent with the rules for implied redefinitions per the specifications.ownedRedefinitions
. See alsoTradeStudies::TradeStudy
model per the resolution to the issue below (because otherwise the above changes result in validation errors being flagged for the model).