search

Systems-Modeling / SysML-v2-Pilot-Implementation

Proof-of-concept pilot implementation of the SysML v2 textual notation and visualization
GNU Lesser General Public License v3.0
114 stars 23 forks source link

ST6RI-745 Inherited references are not properly rendered (PlantUML) #538

Closed himi closed 3 months ago

himi commented 4 months ago

Mainly due to my mistakes, some inherited references were not correctly rendered with SHOWINHERITED style and this PR fixes those issues.

Notice that ST6RI-745 branches out from ST6RI-744. So it contains the fixes in ST6RI-744 as well.

himi commented 4 months ago

After this fix:

part p1 {
    part p11;
    part p12 :> p11;
}
part p2 :> p1;

is correctly rendered with SHOWINHERITED in Interconnection view as:

Screenshot 2024-02-23 at 11 32 18 AM

himi commented 4 months ago

Also the example below:

action a1 {
        action a11 {
            out output;
        }
        flow f1 from a11.output to a12.input;
        action a12 {
             in input;
        }
}
action a2 :> a1;
 action a3 :> a1 {
        action :>> a11;
}

is correctly rendered as:

Screenshot 2024-02-23 at 11 35 47 AM

himi commented 4 months ago

Oops... This still has an issue. a3.a11 must redefine a1.a11 instead of a2.a11. I will fix it.

himi commented 4 months ago

I could fix that issue as well: Screenshot 2024-02-23 at 12 30 41 PM