search

Systems-Modeling / SysML-v2-Pilot-Implementation

Proof-of-concept pilot implementation of the SysML v2 textual notation and visualization
GNU Lesser General Public License v3.0
130 stars 24 forks source link

ST6RI-684 (update) Implement invocation delegates for operations #555

Closed seidewitz closed 7 months ago

seidewitz commented 8 months ago

Certain OCL operations in the specification, related to computing the imported memberships of a Namespace and the inherited memberships of a Type, have particularly complicated implementations. Previously, the implementation of these operations was decomposed into a number of additional methods in the NamespaceImpl and TypeImpl classes (and certain subclasses of those), and some of those methods called each other (rather than just calling on the methods that directly implemented the OCL operations). Part of the update in PR #554 was to move all these operations out of the Impl classes and into the various invocation delegates implementing the specified OCL operations.

However, in the implementation as approved for PR #554, the cross-calls of methods defined in different invocation delegate classes required the dynamic creation of delegate instances using the reflective OperationInvocationDelegateFactory mechanism, in order to properly resolve method overrides. Unfortunately, this turned out to significantly degrade performance of parsing and validation.

This PR implements an alternate approach in which the additional methods in question are moved out of the invocation delegates and into corresponding adapter classes. This has the disadvantage that it couples certain invocation delegates to the adapter implementations. Nevertheless, there is a significant benefit, since overridden methods in adapter subtypes are resolved using normal Java dynamic dispatching. As a result, the performance goes back to being essentially the same as it as it was before the implementation of PR #554.

seidewitz commented 7 months ago

PR #556 proposes an alternative solution to the problem addressed in this PR which is a smaller change to the code already adopted in PR #554 than is proposed in this PR. However, the adapter-based approach proposed here is arguable a simpler more direct approach to handling the additional methods in question than that originally introduced in PR #554, and it is consistent with some previous cases of moving additional state and methods from Impl classes to adapter classes. It also seems to perform slightly better than the approach of PR #556.

So, the decision has been made to accept this PR rather PR #556, though the ST6RI-486-2 branch of #556 will be retained for possible future reference.