search

Systems-Modeling / SysML-v2-Release

The latest incremental release of SysML v2. Start here.
GNU Lesser General Public License v3.0
417 stars 56 forks source link

BodyExpressionMember vs. ExpressionBodyMember #90

Closed harttraveller closed 3 months ago

harttraveller commented 4 months ago

Hi, thanks for the great work on this! Quick question relating to the KerML EBNF meta-model:

On page 100 of the KerML documentation it defines a select expression as the following:

SelectExpression : SelectExpression =
    ownedRelationship += PrimaryArgumentMember '.?'
    ownedRelationship += BodyExpressionMember

However as best as I can tell, BodyExpressionMember is not defined. ExpressionBodyMember is however defined, on page 102:

ExpressionBodyMember : FeatureMembership =
    ownedMemberFeature = ExpressionBody

I was thinking this is a typo, and BodyExpressionMember should be ExpressionBodyMember in the select/collect expressions - but I wanted to double check to confirm. I figured I'd open a GitHub issue so it can be fixed (on the off chance it is a typo).

Thanks for your time!

seidewitz commented 3 months ago

Actually, BodyExpressionMember should be replaced with BodyArgumentMember in both CollectExpression and SelectExpression. BodyArgumentMember is defined in subclause 8.2.5.8.2 along with CollectExpression and SelectExpression, just below FunctionOperationExpression.

Thanks for reporting this issue. However, for future reference, any issues with the specification document should be reported to OMG at https://issues.omg.org/issues/create-new-issue, not on GitHub. Now that the specification has been adopted by OMG, the only way changes can be made is through the formal issue resolution processes. For this time, though, I have created an OMG issue for you: https://issues.omg.org/issues/KERML_-83.

harttraveller commented 3 months ago

Thank you @seidewitz - appreciate the help!