take another look at addFluxbound

[bgoli]

Taking a look at this, this is really old code. Try consolidate addReaction and addFluxBound to be more flexible.

[willigott]

In this context, I recently ran into the following issue(?):

from cbmpy.CBModel import FluxBound

random_dict = {'a': [1, 2]}

fb = FluxBound(f"{random_dict}_upper_bnd", random_dict, 'lessEqual', 10)

fb.getReactionId()
# returns {'a': [1, 2]}

fb.getId()
# returns "{'a': [1, 2]}_upper_bnd"

Clearly, that was by accident, I actually wanted to use the key and not the dictionary itself. Intuitively, I would say that it should not be allowed to use anything else but strings for IDs.

[bgoli]

This has been fixed in 7627832, model component constructors and now check that str(pid) is a valid id. Standardised the behaviour of classes that redefine setId and those using the base function.