search

SystemsBioinformatics / ecmtool

Uncover organisms' metabolic blueprints
MIT License
12 stars 6 forks source link

Install `lrslib` with apt #24

Closed onewhaleid closed 1 year ago

onewhaleid commented 1 year ago

The link to the lrslib source code is broken, and the compilation procedure appears to have changed between 0.71 and 0.72.

This pull request installs lrslib with apt instead, which includes mplrs, the parallel wrapper for redund. https://manpages.debian.org/unstable/lrslib/redund.1.en.html

tjclement commented 1 year ago

Hi @onewhaleid, thanks for sending over a pull request. There was a reason why we install 0.71a instead of 0.72, but I need to think about what it was again. I'll run our tests on the apt-installed 0.72 to see what might come up.

Out of interest, what were you running into with the manually-installed 0.71a? You mentioned the link is broken, but it seems to work fine here; maybe there was a temporary server issue at McGill?

onewhaleid commented 1 year ago

You're right; the McGill server is back up. The only issue I had with 0.71a was the server outage :smile:

tjclement commented 1 year ago

Thanks for sharing! I'll close this PR for now then, as we know that the current configuration works correctly.

We'd be interested to learn what you're using ecmtool for, so if you're willing to share please let us know in the comments here (or shoot an email privately to science at tomclement.nl). Cheers!