SystemsGenetics / ACE

Accelerated Computational Engine (ACE) is a GPU-enabled framework to simplify creation of GPU-capable applications
http://SystemsGenetics.github.io/ACE
GNU General Public License v2.0
1 stars 1 forks source link

Replaced IntegerArray with DataFrame #76

Closed bentsherman closed 5 years ago

bentsherman commented 5 years ago

Since GEMs are actually just dataframes, the DataFrame object should work out-of-the-box with GEM files. I tested by running import, then transform, then export. I can view the dataframes just fine in qaceex. Serial and OpenCL both seem to work.

Here's a quick-n-dirty script for testing purposes:

IN_TXTFILE="Yeast.txt"
IN_TABFILE="a.tab"
OUT_TABFILE="b.tab"
OUT_TXTFILE="b.txt"
GPU=1

# adjust aceex settings
aceex settings set logging off

# import dataframe
aceex run import --in $IN_TXTFILE --out $IN_TABFILE

# math transform
if [[ $GPU = 1 ]]; then
    aceex settings set opencl 0:0
    aceex run transform \
        --in $IN_TABFILE \
        --out $OUT_TABFILE \
        --type multiplication \
        --amount 10
else
    aceex settings set opencl none
    aceex run transform \
        --in $IN_TABFILE \
        --out $OUT_TABFILE \
        --type multiplication \
        --amount 10
fi

# export dataframe
aceex run export --in $OUT_TABFILE --out $OUT_TXTFILE
bentsherman commented 5 years ago

@4ctrl-alt-del if you want to make any changes you can just commit to the dataframe branch and your commits will automatically be added to the PR when you push them. I think you can also make inline comments under the "Files Changed" tab if you want to be specific.

4ctrl-alt-del commented 5 years ago

After testing myself seems to work perfectly. All the commenting seems to be in place too, going to merge in pull request...