SystemsGenetics / GEMmaker

A workflow for construction of Gene Expression count Matrices (GEMs). Useful for Differential Gene Expression (DGE) analysis and Gene Co-Expression Network (GCN) construction
https://gemmaker.readthedocs.io/en/latest/
MIT License
33 stars 16 forks source link

Palmetto-related tweaks #241

Closed bentsherman closed 2 years ago

bentsherman commented 2 years ago

This PR adds a number of tweaks that emerged as a result of me testing GEMmaker 2.0 on Palmetto. I will briefly describe them here:

I apologize for the conglomeration of changes but it's a bunch of small changes so I figure it would be easier to hash them out in one thread. Let me know if I need to change anything to stay consistent with nf-core guidelines.

bentsherman commented 2 years ago

@spficklin I have moved all of the Palmetto-specific settings into a separate config file. Please review my remaining concern about the start_first_batch process.

bentsherman commented 2 years ago

@spficklin I think we've resolved everything. No more Palmetto-specific settings but a bunch of fixes and aesthetic improvements that I made while testing the pipeline on Palmetto. It's ready to merge.

spficklin commented 2 years ago

Changes looked good and it ran fine on my end.... Merging!