search

SystemsGenetics / KINC

Knowledge Independent Network Construction
MIT License
11 stars 4 forks source link

Bug in conditional testing due to ordering of samples #108

Closed spficklin closed 5 years ago

spficklin commented 5 years ago

If the samples in the annotation matrix don't match the order in the expression matrix then it can lead to false edges. As per a conversation on Slack with @MitchsGreer. The sample string for the edge is used to map the conditions but there is a missing step to check the ordering.

MitchsGreer commented 5 years ago

Added support for out of order samples in the annotation matrix in commit e4a40ba0b7d4153110f79b11ead9ea36335f5aee. I also added a check for the correct sample size and sample names in commit 849b60480475873cecf4ce14053312ca426b139c.