Closed JohnHadish closed 4 years ago
The issue is that in the first case the filters also have a threshold and the comma is used to separate filter name and filter threshold. I would recommend something like this:
--filter-rsquare filter1=t1,filter2=t2, ....
--feat-types type1,type2, ...
But I see from #121 that the --filter-pvalue
option could contain commas in the name, and you want to use commas to delineate different types of operators. So I think the way it is now is fine, especially if it matches the syntax from KINC.R (which I don't know if it does).
Also the command-line help for --feat-types
does tell you to use commas:
You can list as many features by separating them with commas, with no spaces around commas.
I agree with @bentsherman that it's okay to have different delimiters in these different analytics. The only way we could unify them would be to put two colons on the cond-test --feat-types
and I'm leary to make such a change now that everything is working! I vote we leave as is.
The method for separating multiple conditions is inconsistent between commands.
For example: In
run extract --filter-rsquare
, multiple conditions are separated with::
Where as in
run cond-test --feat-types
, multiple conditions are separated with,
(In addition, having the comma as a separator is not explicitly stated in the documentation, but was determined through trial and error)I suggest that a standard separator for conditions be picked to reduce confusion