search

SystemsGenetics / KINC

Knowledge Independent Network Construction
MIT License
11 stars 4 forks source link

Conditional filtering doesn't work with MPI #124

Closed spficklin closed 4 years ago

spficklin commented 4 years ago

When running the cond-test analytic with MPI the program fails. After discussion with @4ctrl-alt-del it seems there's a bug in the code. Here's the solution indicated by @4ctrl-alt-del

in your ConditionalTest::MakeResult interface you return a generic EAbstractAnalyticBlock which is incorrect, it should be your implemented ConditionalTest::ResultBlock

spficklin commented 4 years ago

@4ctrl-alt-del . When I look at the makeResult() function of the conditiontest.cpp file it essentially has the same code as the similarity.cpp file. So, I don't get why it's working for similarity but not for the conditionatest code? In QT Creater, if I mouse over the WorkBlock function call it indicates it's referencing the ConditionalTest::WorkBlock::WorkBlock which seems correct.

spficklin commented 4 years ago

Oh nevermind. I was looking at the wrong function. I now see what the problem is as per @4ctrl-alt-del 's comment.