search

SystemsGenetics / KINC

Knowledge Independent Network Construction
MIT License
11 stars 4 forks source link

Bug in refactoring of Extract classes #142

Closed spficklin closed 4 years ago

spficklin commented 4 years ago

@bentsherman can you check this commit: https://github.com/SystemsGenetics/KINC/commit/149fdb88d6f6a39dbb219bb23a78b51735c3162a

It seems in the new 3.4.1 release the output formats are not correct. It seems to be a problem with the fact that this enum was reordered in that commit:

https://github.com/SystemsGenetics/KINC/blob/b6891563c597eff6b6b63e9e3c3d4f3d4fae0242/src/core/extract.h#L37-L55

But this ordering was not:

https://github.com/SystemsGenetics/KINC/blob/b6891563c597eff6b6b63e9e3c3d4f3d4fae0242/src/core/extract_input.cpp#L11-L17

And when the arguments are parsed the index from that second set is used in the first set:

https://github.com/SystemsGenetics/KINC/blob/b6891563c597eff6b6b63e9e3c3d4f3d4fae0242/src/core/extract_input.cpp#L198-L199

So, what ends up happening is that if someone specifies 'tidy' they actually get 'graphml' output.

spficklin commented 4 years ago

A PR was submitted to fix this.