Open JohnHadish opened 4 years ago
Perhaps we should specify a real limit instead of using the maximum integer size.
@4ctrl-alt-del can you suggest some reasonable limits for these options?
@JohnHadish @spficklin The maximum limits for these options will vary from system to system depending on things like amount of RAM and the GPU model. In other words they are limited by the underlying hardware. So there are really no sensible software-imposed limits that we could use, other than the integer limits.
If you don't like the help text because it seems ugly, I suppose we could remove the maximum settings from the code. I've never tried it but I think ACE just wouldn't check against a maximum. In that case the user would be able to specify some huge number and I'm not sure what would happen, ACE might throw a parsing error or might allow the number to overflow which would be a silent error. Of course the user will probably never come close to such large numbers for these particular parameters... right?
When using the KINC help documentation, "maximum" values for
--bsize
,--gsize
, and--lsize
are set to 2147483647:I am sure there is an interesting reason for this number, but to me, it makes it look like the KINC documentation is glitching. I suggest that we remove this "maximum" value from the documentation, as it realistically provides no useful information .
Rather than have this value be mentioned in the documentation, KINC could simply send an error in the unlikley event that a user chooses a number greater than 2147483647:
Proposed new documentation for these parameters: