search

SystemsGenetics / KINC

Knowledge Independent Network Construction
MIT License
11 stars 4 forks source link

kinc-filter-rank.R `--top_n` #155

Closed JohnHadish closed 4 years ago

JohnHadish commented 4 years ago

The --top_n option for kinc-filter-rank.R does not do what the documentation says. When I set it to 10000 it returned 16553789 edges. There are many edges which receive identical rankings, so while the file only goes up toi rank 10000 there can be many edges for a specific rank. If I select only the top 10,000 edges, I only will get to rank 192.

spficklin commented 4 years ago

@JohnHadish I think there might be confusion about what that option does. It doesn't select n edges, but the top n ranked edges. Some edges can have the same rank. Also, it will select each the top n ranked edges per condition as well.

spficklin commented 4 years ago

I went ahead and fixed this issue so that it is no longer confusing. PR #177 has been submitted.