Closed spficklin closed 4 years ago
@bentsherman would you mind looking this over? If you don't have time for a functional review if you can just check the changes and see if you are okay with them?
The only outstanding item on this is clarification about the -cpu
and -gpu
tags on the images which is missing in the documentation.
Also, once this PR is merged and after we do the 3.4.2 release we can rebuild the images for DockerHub. For the 3.4.2 release we just have this PR and the other #171 . Then we can release!
Oh, one other note.... If you try to build the images you'll see some warnings when building KINC about unused variables. That has been fixed in #171 so no need to try to clean that up. It will go away once all the PRs are merged.
Hi @bentsherman. I believe I have resolved all of the issues you raised on this PR. I did update the Dockerfile a bit more to make it easier to build just a cpu or gpu version. Also I added a new develop
tag and set latest
to point to the actual latest release rather than the develop branch. Other than that, the only other changes I made were to fix issues.
Can you review again? I'm hoping to do a release on Monday for Iris.
Thanks @bentsherman
This PR updates the Docker file to support the RScripts and the 3D python viewer so that users who want to use the Docker image to avoid installing all of the dependencies can do so.
This PR makes the following changes:
lastest
images now have ACE hardcoded to 3.2.0 rather thandevelop
. This is because the develop branch can have, at any point in time, experimental code. I think thelatest
image should be the latest of development version of KINC and not the latest of of ACE.-cpu
and-gpu
tagged images. That should be included as the current image name isn't correct in the commands.nvidia-docker
to justdocker
with the--gpus all
option. I wasn't able to run the image withnvidia-docker
as that didn't exist on my machine.Unfortunately, all of these changes makes the image rather large and take a long time to build.