SystemsGenetics / KINC

Knowledge Independent Network Construction
MIT License
11 stars 4 forks source link

Consistency of --preout and --postout #175

Open JohnHadish opened 4 years ago

JohnHadish commented 4 years ago

When kinc help run similarity is run, preout and postout default value to true (all lower case)

--preout <value>
Value Type: Boolean
Default Value: true
Whether to remove pre-clustering outliers.

--postout <value>
Value Type: Boolean
Default Value: true
Whether to remove post-clustering outliers.

In the example documentation, they are set to TRUE (all uppercase)

kinc run similarity \
   --input "PRJNA301554.slim.GEM.log2.emx" \
   --ccm "PRJNA301554.slim.GEM.log2.ccm" \
   --cmx "PRJNA301554.slim.GEM.log2.cmx" \
   --clusmethod "gmm" \
   --corrmethod "spearman" \
   --minexpr -inf \
   --minsamp 25 \
   --minclus 1 \
   --maxclus 5 \
   --crit "ICL" \
   --preout TRUE \
   --postout TRUE \
   --mincorr 0 \
   --maxcorr 1 

In the c++ standard, true is a bool where as TRUE is not defined.

bentsherman commented 3 years ago

C++ types aren't relevant to how command-line arguments are parsed, as they are all strings. You'd have to check the ACE code that handles argument parsing, but I believe ACE supports both "true" and "TRUE" for boolean arguments.