Closed PhMemmel closed 2 years ago
PhMemmel
commented
2 years ago Feature is complete, just unit tests missing, that's the only reason why this is still marked as draft.
I'm not really happy about the styling of the mforms for course and section selection, but mforms somehow make it hard to style it properly. If someone has an idea of improving this, please let me know :-)
PhMemmel
commented
2 years ago The PR is now ready for review, it now includes behat and unit tests, small fixes have been applied found while writing the tests.
@Syxton Let me know if you do not have time for that. If it's fine for you I can also try to ask for an internal review in our organization.
Syxton
commented
2 years ago @PhMemmel Just wanted to let you know I don't mean to ignore this. Really excited to see this new feature. I'll get to it when I have some spare time. Thanks for all you do!
PhMemmel
commented
2 years ago @Syxton Great, thank you! :-)
PhMemmel
commented
2 years ago Just rebased due to the recent merge to master
Syxton
commented
2 years ago @PhMemmel Great work. This is a really cool addition.
Syxton
commented
2 years ago @PhMemmel All the "issues" were very minor and after discussion I understand why decisions were made. I am good to go ahead with this feature.
PhMemmel
commented
2 years ago Nice to hear, thank you for sharing your thoughts and ideas!
PhMemmel
commented
2 years ago @Syxton Just as a reminder: As I introduced new lang strings in this PR we would need to publish a new release to moodle.org, so AMOS can pick up the new lang strings
Syxton
commented
2 years ago @PhMemmel Ok, I'll issue a new release for both branches by the end of the week. I'll keep looking at them as a sanity check before release.
PhMemmel
commented
2 years ago Great! As always: Thank you very much!
Closes #52