SzFMV2018-Osz / AutomatedCar-B

Working repository for the subject "Szoftverfejlesztés multinacionális vállalatoknál" @OE-NIK 2018 ősz B csoport
0 stars 0 forks source link

Hierarchikus heterogen #123

Closed porkolabgergo closed 5 years ago

porkolabgergo commented 5 years ago

Class structure redesgin, new WorldObject classes

Added functionalities

The XML reader functions now can parse the xml objects to the specific classes.

XmlObject class added, for a simple representation for the visualization team. Deleted classes: DynamicObject, StaticObject, ControllabeCar Data reading methods moved from Utils to DataReader class.

Other (test, documentation addition, refactor)

-Class structure refactored -Xml reading methods moved from Utils to DataReader class -Test classes added for XmlObject

porkolabgergo commented 5 years ago

@pintergreg itt a continuous-integration/travis-ci/push és a continuous-integration/travis-ci/pr -nél lévő faileket hogyan lehet kiküszöbölni?

codecov[bot] commented 5 years ago

Codecov Report

Merging #123 into TeamB1 will decrease coverage by 14.53%. The diff coverage is 7.91%.

Impacted file tree graph

@@              Coverage Diff              @@
##             TeamB1     #123       +/-   ##
=============================================
- Coverage     55.11%   40.58%   -14.54%     
+ Complexity      145       87       -58     
=============================================
  Files            29       41       +12     
  Lines           557      478       -79     
  Branches         23       29        +6     
=============================================
- Hits            307      194      -113     
- Misses          239      275       +36     
+ Partials         11        9        -2
Impacted Files Coverage Δ Complexity Δ
src/main/java/hu/oe/nik/szfmv/common/Utils.java 93.33% <ø> (+58.61%) 5 <0> (-4) :arrow_down:
...ava/hu/oe/nik/szfmv/automatedcar/AutomatedCar.java 0% <ø> (ø) 0 <0> (ø) :arrow_down:
src/main/java/hu/oe/nik/szfmv/Main.java 0% <ø> (ø) 0 <0> (ø) :arrow_down:
.../nik/szfmv/environment/worldobjectclasses/Car.java 0% <0%> (ø) 0 <0> (?)
...k/szfmv/environment/worldobjectclasses/NpcCar.java 0% <0%> (ø) 0 <0> (?)
...nik/szfmv/environment/worldobjectclasses/Road.java 0% <0%> (ø) 0 <0> (?)
...fmv/environment/worldobjectclasses/NonMovable.java 0% <0%> (ø) 0 <0> (?)
...zfmv/environment/worldobjectclasses/Crosswalk.java 0% <0%> (ø) 0 <0> (?)
...szfmv/environment/worldobjectclasses/RoadSign.java 0% <0%> (ø) 0 <0> (?)
...c/main/java/hu/oe/nik/szfmv/environment/World.java 0% <0%> (-100%) 0 <0> (-11)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 788f76d...8cd7dd1. Read the comment docs.

porkolabgergo commented 5 years ago

@ral2bp valami tanács, miért failelnek el a Travis check-ek?

ravaszla commented 5 years ago

@ral2bp valami tanács, miért failelnek el a Travis check-ek?

A travis CI átmegy, a codecoverage és a codefactor nem kötelező, de a details alatt látható, mi bajuk. Ha megvan a 2 approve, merge-ölhető a PR.