#188 Enhance Car Speed (Engine/PowerTrain)

[aether-fox]

---

This epic story continues this summer (spring, but this is not a spring application)! Come and see this May the ever-evolving world of merges continuing on #193

Associated main ticket: #188

I spent a whole day figuring out how the hell transmission gears work in a car and how to implement them (am not really a car guy). I don't say it is perfect what I have written, but possibly its skeleton is quite usable for improving it incrementally. Currently D transmission work on level 1 always and does not react to high RPM (defined its maximum value: 5000 RPM). Most values are empirically gained and by high chance will be subject of change.

Working

• gas pedal value is used in order to calculate RPM increment/decrement
• when gas pedal is completely released, there is motor break effect and the car stops
• break pedal works, but when released trust is obtained from engine again (how does this work in real scenario? possibly RPM decreases then much faster?)
• steering wheel is still horrible, but I guess it's because we use keyboard, otherwise realistic (possibly a rotating wheel image on GUI would help a bit? Or faster wheel reaction to keys?)
• car can back up in R/Reverse transmission mode (going backwards) realistically

Open Questions

• How do we receive information if the user wants to increment transmission level within D? I guess it should be automatic, because we want automatic transmission. I am unsure, am I right here?
• Should break decrease RPM directly? Currently it is involved in the last stage of speed calculation and decreases already generated thrust received from the engine. And so when break is released, the trust gets higher again, because albeit RPM decreases, but not immediately.

Known Bugs

• On very low speed, there is a slicing effect on the car. Might be the result of trigonometric function inaccuracy on very low angles. I'll look into it.

Testing

I tested the implementation manually by running the application. Would like to add unit tests later when the structure and roles in the code get more stable as how exactly the powertrain calculates trust and speed for the car.

[codecov[bot]]

Codecov Report

Merging #192 into TeamA3 will decrease coverage by 2.77%. The diff coverage is 12.83%.

@@             Coverage Diff              @@
##             TeamA3     #192      +/-   ##
============================================
- Coverage     44.72%   41.95%   -2.78%     
- Complexity      275      279       +4     
============================================
  Files            53       58       +5     
  Lines          1878     2019     +141     
  Branches        144      173      +29     
============================================
+ Hits            840      847       +7     
- Misses          990     1121     +131     
- Partials         48       51       +3     

Flag	Coverage Δ	Complexity Δ
#unittests	41.95% <12.83%> (-2.78%)	279.00 <12.00> (+4.00)	:arrow_down:

Impacted Files	Coverage Δ	Complexity Δ
...ava/hu/oe/nik/szfmv/automatedcar/AutomatedCar.java	28.57% <0.00%> (+10.05%)	3.00 <0.00> (ø)
.../szfmv/automatedcar/powertrain/ITransmission2.java	0.00% <0.00%> (ø)	0.00 <0.00> (?)
...ik/szfmv/automatedcar/powertrain/Transmission.java	0.00% <0.00%> (-26.00%)	0.00 <0.00> (-2.00)
...tomatedcar/powertrain/off/AccelerationModel1D.java	0.00% <0.00%> (ø)	0.00 <0.00> (?)
...tomatedcar/powertrain/off/AccelerationModel2D.java	0.00% <0.00%> (ø)	0.00 <0.00> (?)
...atedcar/virtualfunctionbus/VirtualFunctionBus.java	66.66% <ø> (ø)	2.00 <0.00> (ø)
...functionbus/packets/powertrain/ICarMovePacket.java	0.00% <0.00%> (ø)	0.00 <0.00> (?)
...mv/automatedcar/powertrain/SimpleTransmission.java	10.44% <10.44%> (ø)	2.00 <2.00> (?)
...v/automatedcar/powertrain/CarTransmissionMode.java	38.46% <11.11%> (-61.54%)	1.00 <0.00> (ø)
...ava/hu/oe/nik/szfmv/automatedcar/math/IVector.java	38.27% <16.66%> (-17.73%)	14.00 <2.00> (+2.00)	:arrow_down:
... and 11 more