Closed aether-fox closed 4 years ago
Merging #203 into master will increase coverage by
0.53%
. The diff coverage is41.86%
.
@@ Coverage Diff @@
## master #203 +/- ##
============================================
+ Coverage 46.97% 47.50% +0.53%
- Complexity 302 341 +39
============================================
Files 54 58 +4
Lines 1982 2143 +161
Branches 165 186 +21
============================================
+ Hits 931 1018 +87
- Misses 997 1051 +54
- Partials 54 74 +20
Flag | Coverage Δ | Complexity Δ | |
---|---|---|---|
#unittests | 47.50% <41.86%> (+0.53%) |
341.00 <53.00> (+39.00) |
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
.../java/hu/oe/nik/szfmv/automatedcar/CarVariant.java | 0.00% <0.00%> (ø) |
0.00 <0.00> (?) |
|
...k/szfmv/automatedcar/powertrain/ITransmission.java | 0.00% <0.00%> (ø) |
0.00 <0.00> (?) |
|
...atedcar/virtualfunctionbus/VirtualFunctionBus.java | 66.66% <ø> (ø) |
2.00 <0.00> (ø) |
|
...s/packets/hmioutputpackets/ToPowerTrainPacket.java | 4.00% <ø> (ø) |
1.00 <0.00> (ø) |
|
...functionbus/packets/powertrain/ICarMovePacket.java | 0.00% <0.00%> (ø) |
0.00 <0.00> (?) |
|
...ava/hu/oe/nik/szfmv/automatedcar/AutomatedCar.java | 21.05% <9.09%> (+5.66%) |
3.00 <0.00> (ø) |
|
.../nik/szfmv/automatedcar/powertrain/PowerTrain.java | 26.41% <20.45%> (-5.85%) |
4.00 <4.00> (+1.00) |
:arrow_down: |
...ava/hu/oe/nik/szfmv/automatedcar/math/IVector.java | 38.27% <25.58%> (-17.73%) |
14.00 <5.00> (+2.00) |
:arrow_down: |
...n/java/hu/oe/nik/szfmv/automatedcar/math/Axis.java | 61.81% <33.33%> (-0.45%) |
3.00 <0.00> (ø) |
|
...mv/automatedcar/powertrain/SimpleTransmission.java | 54.45% <54.45%> (ø) |
22.00 <22.00> (?) |
|
... and 12 more |
@pintergreg We would like to merge our new powertrain into the master, so car engine/powertrain is more realistic. Please approve this merge if you're okay with it.
General Information
Associated main ticket: #188 Additional related issues: #49 #52 #54 #190 Read trivia if you are bored here: #192 Merges into
master
what was merged intoTeam3
in #192 and #193.Working
R
/Reverse
transmission mode (going backwards) realisticallyOpen Questions
D
? I guess it should be automatic, because we want automatic transmission. I am unsure, am I right here?Known Bugs
Testing
I tested the implementation manually by running the application. Would like to add unit tests later when the structure and roles in the code get more stable as how exactly the powertrain calculates trust and speed for the car.
Within the Furnace
We are currently working on #7 NPC's, so you can expect that next from our mostly 2 membered team. Have a nice day!