Closed aether-fox closed 4 years ago
Merging #222 into master will decrease coverage by
0.52%
. The diff coverage is34.09%
.
@@ Coverage Diff @@
## master #222 +/- ##
============================================
- Coverage 47.26% 46.73% -0.53%
- Complexity 428 444 +16
============================================
Files 69 78 +9
Lines 2780 2929 +149
Branches 269 277 +8
============================================
+ Hits 1314 1369 +55
- Misses 1372 1461 +89
- Partials 94 99 +5
Flag | Coverage Δ | Complexity Δ | |
---|---|---|---|
#unittests | 46.73% <34.09%> (-0.53%) |
444.00 <20.00> (+16.00) |
:arrow_down: |
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
...va/hu/oe/nik/szfmv/automatedcar/CarIndexState.java | 0.00% <0.00%> (ø) |
0.00 <0.00> (?) |
|
...atedcar/cruisecontrol/CruiseControlPacketData.java | 0.00% <0.00%> (ø) |
0.00 <0.00> (?) |
|
...ava/hu/oe/nik/szfmv/automatedcar/math/IVector.java | 37.80% <0.00%> (-0.47%) |
14.00 <0.00> (ø) |
|
...u/oe/nik/szfmv/automatedcar/move/CarMoveInput.java | 0.00% <0.00%> (ø) |
0.00 <0.00> (?) |
|
.../oe/nik/szfmv/automatedcar/move/CarMoveOutput.java | 0.00% <0.00%> (ø) |
0.00 <0.00> (?) |
|
...e/nik/szfmv/automatedcar/sensors/ParkingRadar.java | 86.04% <0.00%> (ø) |
38.00 <1.00> (ø) |
|
...r/virtualfunctionbus/packets/CarControlPacket.java | 0.00% <0.00%> (ø) |
0.00 <0.00> (?) |
|
...v/automatedcar/move/CarMoveCalculatorStrategy.java | 22.22% <22.22%> (ø) |
2.00 <2.00> (?) |
|
...atedcar/virtualfunctionbus/VirtualFunctionBus.java | 53.84% <33.33%> (-12.83%) |
2.00 <1.00> (ø) |
|
...ava/hu/oe/nik/szfmv/automatedcar/AutomatedCar.java | 44.44% <44.44%> (+20.76%) |
4.00 <1.00> (ø) |
|
... and 13 more |
@pintergreg four of our features/increments/additions are ready to be integrated into master
, see pull request description for details.
Changes to merge into
master
CruiseControl
ICruiseControlPacket
loop()
call) via@DependsOn
Fix Car Sliding
See the bug and solution here. Car was sliding in peculiar circumstances due to improper handling of coordinates.
Add Tempomat Component
The
CruiseControl
component got added and integrated into the VFB of theAutomatedCar
. It is empty yet, a placeholder for Sprint 3 developments of Team 3.Add Tempomat Output Packets
Added output packets for tempomat, not yet used. Also, refactored car control packet interfaces a bit to share interface with packet of
Driver
, since the data provided is essentially the same thing (butDriver
provides additional information, like switching things on/off, etc.).Add Support for VFB for Dependency
Now there is a new VFB implementation, which extends the original one to preserve compatibility. The new one is calleld
DepdendentVirtualFunctionBus
and takes care of the order of callingloop()
on the registered components. Dependency satisfaction can be verified after registering all components manually. Circular dependency throws exception meanwhile registration attempt.