search

Szpadel / chrome-headless-render-pdf

225 stars 67 forks source link

Use google-chrome-stable instead of google-stable #56

Closed cesarizu closed 5 years ago

cesarizu commented 5 years ago

This PR fixes the name for the executable changing it from google-stable to google-chrome-stable.

Szpadel commented 5 years ago

I would rather want to keep both options available, because naming might be really different on different distributions

cesarizu commented 5 years ago

AFAIK no distribution provides Google Chrome by itself but Chromium (which has a different binary name in any case). Google Chrome is only distributed by Google themselves. Doing a quick search for google-stable in GitHub shows just this project and only one other mention of this executable name, while google-chrome-stable and google-chrome return hundreds of thousands of results.

In any case, I might be wrong here, if anyone knows where this executable is used please let me know.