Closed Tofugrass closed 3 years ago
I believe the JSON is malformed in https://github.com/Szum123321/elytra_swap/blob/2.x/src/main/resources/elytra_like_item_set.json .
The A on line 9 is causing errors. Commit 6678e9a.
Yes, that A shouldn't be there but I committed it yesterday and that A is not present in any of the releases.
Ok, so I tested that and everything seems to be ok. So now I have to ask you a few questions like, what additional mods are you using?
Can you push the new build? It might just fix itself with the new build. We should try that before anything else.
Ok, I'll do that today, but, once again, it wasn't broken because of that A
The only mods I have are fabric api and netherite plus
But what versions?
ive tried a bunch of versions. which combination works?
Yesterday this configuration wokred for me:
so you are able to use netherite elytra from a standing position with only firework rockets in your inventory?
yes
what fabric loader build?
fabric-loader-0.9.2+build.206-1.16.2
Have you tried deleting config?
Wow, I think you're right. It just stopped working.
imagine that
push the fix lmao
it might not fix it but then at least ill be on the same build as you and we can troubleshoot
Since the last release I changed quite a bit the mod compatibility part, so that's probably why it works now. I have to do some more testing, but if you would like I can share current test build with you
Yes that would be great, I can help test.
Just give me a minute to build everything for 1.16.2
elytra_swap-2.1.1-1.16.2.tar.gz Github doesn't allow jars so I had to tar it
I am failing to start minecraft with this version.
Here is a stracktrace
at net.szum123321.elytra_swap.inventory.ElytraItemFilter.
Additionally:
java.lang.NoSuchMethodError: java.util.stream.Collectors.toUnmodifiableSet()Ljava/util/stream/Collector;
at net.szum123321.elytra_swap.inventory.ElytraItemFilter.
Oh! Right, I'm guessing you're using java 8?
oh, probably. is there a java 9 i should update to?
No, I just use java 11 most of the time, so I might be possible that I've used feature that just doesn't exist in java 8.
elytra_swap-2.1.1-1.16.2.tar.gz It should all work now
Works in Java 11. I did not try it in 8. Thank you very much good sir.
Ok, thanks for help with testing! New release should be available soon!
There is a small bug when interacting with the Netherite Plus mod.
When the user is wearing Netherite Elytra, and does not have a normal elytra to swap to, the take off feature does not work.
When the user is wearing Netherite Elytra, and DOES HAVE A NORMAL ELYTRA TO SWAP TO, the take off feature works fine, and the user can take off while wearing the netherite elytra. When the user descends, the netherite elytra are treated as a chestplate, so the user swaps to normal elytra, but replaces it with netherite elytra upon landing.
I think netherite elytra are being treated as a chestplate rather than an elytra item.