search

Szum123321 / elytra_swap

Automatic elytra replacement with chestplace and more
https://www.curseforge.com/minecraft/mc-mods/elytra-swap
GNU General Public License v3.0
3 stars 2 forks source link

Fireworks takeoff the player without elytra #20

Open Tofugrass opened 3 years ago

Tofugrass commented 3 years ago

when the global swap config is set to disable, the player is able to takeoff without wearing an elytra. the mod still looks in the inventory and if it finds an elytra item, it will takeoff the player, however it will not swap elytra onto the player, so a player without wings will start flying.

Szum123321 commented 3 years ago

If I recall correctly I added that because someone requested it. There still might be some room for improvement, so I'll consider some changes.

Tofugrass commented 3 years ago

It's definitely a bug

MeeniMc commented 3 years ago

Hey, I'm the someone that requested it, but what I got is not exactly what I wanted. The way the settings work now is a fancy way of killing oneself, as it will propel the player in the air in non-flight mode (even when elytra are already equipped!).

What I wanted is the following combination of configuration options:

  1. auto-equip elytra when falling (on/off)
  2. auto-equip armor when landing (on/off)
  3. Rocket launch (on/off)
  4. Auto-equip elytra when using a rocket (on/off)

For my particular use I'd be going with 1. off, 2. on, 3. on, 4.on

The goal being that I'd be able to auto-swap to an elytra on rocket-use, swap back to armor on landing, but fall would not auto-swap.

I think it is important that in this configuration, rocket use while falling/flying does swap-in an elytra (otherwise a touch and go could kill the player).

Keep on the good work, and don't let the rude people get in your head.

Szum123321 commented 3 years ago

Oh. When I read your first request I also thought it was strange idea, but whatever, it all makes sense now. I will add those changes soon-ish, as I don't have much free time.