search

Szum123321 / textile_backup

Backup Mod for Fabric
https://www.curseforge.com/minecraft/mc-mods/textile-backup
GNU General Public License v3.0
90 stars 29 forks source link

Backups not works with C2ME mod #133

Closed diskree closed 12 months ago

diskree commented 1 year ago

Auto backup is not working in single player (works only backups when shutdown). It's just not send "Done!" message and folder is missing. Configs: Default I use this mod in my mod pack, included mods here: javaw_7KLAq8CJw3

Logs:

[19:04:21] [Server thread/INFO]: [Textile Backup] Warning! Server backup will begin shortly. You may experience some lag.
[19:04:21] [Server thread/INFO]: [Textile Backup] Backup started by: Timer on: 2023.07.23_19-04-21
[19:04:21] [pool-5-thread-1/INFO]: [Textile Backup] Saving server...
[19:04:21] [pool-5-thread-1/INFO]: [STDERR]: java.util.ConcurrentModificationException: Attempted to call MinecraftServer#saveAll async
[19:04:21] [pool-5-thread-1/INFO]: [STDERR]:    at net.minecraft.server.MinecraftServer.handler$baa000$c2me-fixes-general-threading-issues$preventAsyncSaveAll(MinecraftServer.java:6819)
[19:04:21] [pool-5-thread-1/INFO]: [STDERR]:    at net.minecraft.server.MinecraftServer.method_39218(MinecraftServer.java)
[19:04:21] [pool-5-thread-1/INFO]: [STDERR]:    at net.szum123321.textile_backup.core.create.ExecutableBackup.call(ExecutableBackup.java:69)
[19:04:21] [Render thread/INFO]: [System] [CHAT] [Textile Backup] Warning! Server backup will begin shortly. You may experience some lag.
[19:04:21] [pool-5-thread-1/INFO]: [STDERR]:    at net.szum123321.textile_backup.core.create.ExecutableBackup.call(ExecutableBackup.java:25)
[19:04:21] [pool-5-thread-1/INFO]: [STDERR]:    at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
[19:04:21] [pool-5-thread-1/INFO]: [STDERR]:    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
[19:04:21] [pool-5-thread-1/INFO]: [STDERR]:    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
[19:04:21] [pool-5-thread-1/INFO]: [STDERR]:    at java.base/java.lang.Thread.run(Thread.java:833)
diskree commented 1 year ago

Damn, I just found it myself, there seems to be a conflict with the C2ME mod

UPD: Yes, it is problem with C2ME

diskree commented 1 year ago

https://github.com/RelativityMC/C2ME-fabric/issues/228

diskree commented 1 year ago

According to this C2ME mixin, we need to execute the world save in the server thread

Szum123321 commented 12 months ago

please move the discussion to #123