Szum123321 / textile_backup

Backup Mod for Fabric
https://www.curseforge.com/minecraft/mc-mods/textile-backup
GNU General Public License v3.0
90 stars 30 forks source link

Lost my backup #157

Closed JJAAMMes closed 1 month ago

JJAAMMes commented 6 months ago

Not exactly a technical issue, when max size of backup is saved and the most previous backup is restored with the backup old world turned on, the old-world backup will replace the most previous backup, so it's deleted and cannot be loaded :(

JJAAMMes commented 6 months ago

probably should add a warning or something when restoring a backup because you won't expect the backup you're trying to restore to be deleted right after you run the command...

ARedstoneMan commented 3 months ago

Same issue here. This seems very counter-intuitive as you would expect the oldest backup to be deleted, not the one you are trying to load. As a more technical player, I want to be able to go back to the same backup multiple times if I mess something up, so it would be helpful if the deletion would prioritize the oldest backup no matter how new backups are created.

Szum123321 commented 1 month ago

RTFM, there's literally an option to do so and it's more than 3 years old. deleteOldBackupAfterRestore. With newer versions the just restored zip file only gets deleted if the restoration succeeds.

On more personal note, i think this is a very reasonable behavior, once a backup is unpacked without any errors, the exact state of the world is present in the game folder. There's little need to keep an exact copy except zipped.