search

Szum123321 / textile_backup

Backup Mod for Fabric
https://www.curseforge.com/minecraft/mc-mods/textile-backup
GNU General Public License v3.0
90 stars 31 forks source link

crash when backup is attempted in version 1.3.0 #29

Closed crabdancing closed 4 years ago

crabdancing commented 4 years ago

See crash log.

Also, here's my config file.

Szum123321 commented 4 years ago

I'm sorry but I'm not a home today, so I can't work on this bug right now. All I can tell you right now is that indeed this crush is caused by Textile Backup Mod.

Szum123321 commented 4 years ago

So I analized your log. Crush is caused be RejectedExecutiomException, which gets thrown when someone tries using closed executor serivece. It looks like you played on single player world, loged out and then logedin. Now I have to tell you that I used my own executor serivece, which gets shut down when server stops. Because I mainly tested this mod on servers this is not a problem. But on single player world when you relog to some world it causes an exception. I will repair it soon.

Szum123321 commented 4 years ago

https://github.com/Szum123321/textile_backup/blob/28641383f95eb11963ec521deb76564fe8f1400d/src/main/java/net/szum123321/textile_backup/TextileBackup.java#L64

This line, to be exact, causes this issue.

Szum123321 commented 4 years ago

Repaired in 31623906d9d539f2e4c0c4a64e479f77e8305769

crabdancing commented 4 years ago

Thanks! I'll open a new issue if I find any more problems! :)