search

SzymonLisowiec / node-CSGODemoReader

A library for reading CS:GO demo files.
MIT License
19 stars 3 forks source link

Few bugs in the Player methods #2

Closed Tirre closed 4 years ago

Tirre commented 5 years ago

Method getEyeAngle() is attempting to call non-defined function "makeAnglePositive()". Method getEyeAngleVector() is attempting to call non-defined function "directionToVector()". Method hasHelmet() is attempting to read the attribute "m_bHasFelmet" which should be "m_bHasHelmet".

Some methods also attempt to return Vector3d or Line3d objects which are also breaking.

"csgodemoreader/src/Entities/Player.js:80 return new Vector3d(xy.x, xy.y, z); ^ ReferenceError: Vector3d is not defined"

Believe these are objects from third-party libraries that are not properly imported?

These are some things that I found that you might want to fix. Really appreciate this project 👍

SzymonLisowiec commented 5 years ago

Hi, Thanks for report bugs. These are forgotten methods from original jsgo. I will fix it in the near future.

caio1985 commented 4 years ago

hi Szymon, wondering if you had the chance to implement these methods. Thanks!

SzymonLisowiec commented 4 years ago

Fixed in https://github.com/SzymonLisowiec/node-CSGODemoReader/commit/458bdcf6f456206dddcd5c7d3e02c7c4965ba88b Please update library to version 1.0.22. Thanks guys ❤