search

SzymonPobiega / NServiceBus.Router

Cross-transport, cross-site and possibly cross-cloud router component for NServiceBus
MIT License
5 stars 10 forks source link

#46 Handle scenarios where correlation ID is present but null #49

Closed davecluderay closed 2 years ago

davecluderay commented 2 years ago

I encountered this issue when routing messages published from an older NServiceBus v3 endpoint. An NServiceBus.CorrelationId header was present in the headers for these messages, but its value was null.

I have updated the three places where that header is retrieved to guard for a null value. If the value is null, it is treated as if the header was not present.

I've also updated TryDecodeTLV, since it makes logical sense to return false if the input is null.

SzymonPobiega commented 2 years ago

Thanks @davecluderay. I'll try to process it and release next week as today we start a long weekend in Poland.

Just curious: does that mean that you run NServiceBus V3 endpoints in production and you need to communicate with them via the Router?

davecluderay commented 2 years ago

Hiya, yeah that is fine Szymon, thank you! Yes, we do have this one older endpoint - we are in the process of upgrading/migrating, so it's an interim solution!

davecluderay commented 2 years ago

Hi @SzymonPobiega any update on when we'll see this released (we are using our own build at the moment)?

SzymonPobiega commented 2 years ago

Hi

I'll try early next week. The master branch contained one WIP item that I need to finish before releasing.

SzymonPobiega commented 2 years ago

Router 3.10.1 is on NuGet with these fixes. It also contains some bug fixes to the auto-publish/auto-subscribe behavior.

davecluderay commented 2 years ago

Thank you!