T-F-S / csvsimple

A LaTeX package for lightweight CSV file processing.
http://www.ctan.org/pkg/csvsimple
LaTeX Project Public License v1.3c
24 stars 5 forks source link

doc: name of filter option args #21

Closed muzimuzhi closed 2 years ago

muzimuzhi commented 2 years ago

Options filter bool, filter expr, and filter ifthen accept an etoolbox, latex3, or ifthen bool expression as their value, respectively, hence each of their doc uses \meta{boolean expression} as the placeholder of value.

But in the last sentence of each of their doc, \meta{condition} is used, which I assume should be \meta{boolean expression}.

diff --git a/doc/latex/csvsimple/csvsimple-l3.tex b/doc/latex/csvsimple/csvsimple-l3.tex
index d8bd01a..0dce40e 100644
--- a/doc/latex/csvsimple/csvsimple-l3.tex
+++ b/doc/latex/csvsimple/csvsimple-l3.tex
@@ -1098,7 +1098,7 @@ The following string compare filters \refKey{/csvsim/filter strcmp} and
 \begin{docCsvKey}[][doc new=2021-06-25]{filter bool}{=\meta{boolean expression}}{no default}
   Only data lines which fulfill a \LaTeX3 \meta{boolean expression} are accepted.
   Note that such an \meta{boolean expression} needs expl3 code.
-  To preprocess the data line before testing the \meta{condition},
+  To preprocess the data line before testing the \meta{boolean expression},
   the option key \refKey{/csvsim/before filter} can be used.
 \begin{dispExample}
 % For convenience, we save the filter
@@ -1191,7 +1191,7 @@ filter test=\iftest{some testing},
   Only data lines which fulfill a \meta{boolean expression} are accepted.
   Every \meta{boolean expression}
   from the \ctanpkg{etoolbox} package is feasible (package loading required!).
-  To preprocess the data line before testing the \meta{condition},
+  To preprocess the data line before testing the \meta{boolean expression},
   the option key \refKey{/csvsim/before filter} can be used.
 \begin{dispExample}
 % \usepackage{etoolbox,booktabs}
@@ -1216,7 +1216,7 @@ filter test=\iftest{some testing},
   Only data lines which fulfill a \meta{boolean expression} are accepted.
   For the \meta{boolean expression}, every term from the \ctanpkg{ifthen} package
   is feasible (package loading required!).
-  To preprocess the data line before testing the \meta{condition},
+  To preprocess the data line before testing the \meta{boolean expression},
   the option key \refKey{/csvsim/before filter} can be used.

 \begin{dispExample}
T-F-S commented 2 years ago

It seems, I missed the accompanying email of this issue (too many emails)...

But, yes, you are right. I will correct this. Thank you.

T-F-S commented 2 years ago

Resolved with https://github.com/T-F-S/csvsimple/releases/tag/v2.3.1