Closed muzimuzhi closed 3 months ago
I just opened https://github.com/latex3/latex3/issues/1424 to ask if it's sensible to relax the documented form of first argument of \fp_compare:nTF
.
Since these number tests a mere wrappers for LaTeX3 functions, I want to keep the documentation quite short here, because possible users are hinted to \fp_compare:nTF
and \int_compare:nTF
and the documentation of interface3.pdf
should be the prime source, not the csvsimple-l3
documentation.
But you are right that the current description is misleading. I would go for the following:
Several other <floating point expression>
arguments may need the same renaming. For example csvsim/filter fp
.
I realized that the example for csvsim/filter fp
contains a working content for \fp_compare_p:n
with logical &&
which is not covered by the (current?) documention inside interface3.pdf
.
So, I will move the &&
part to csvsim/and filter fp
.
I realized that the example for
csvsim/filter fp
contains a working content for\fp_compare_p:n
with logical&&
which is not covered by the (current?) documention insideinterface3.pdf
.So, I will move the
&&
part tocsvsim/and filter fp
.
Not necessary. <fp expr>
does support &&
operation, as well as ||
.
Not necessary.
<fp expr>
does support&&
operation, as well as||
.
I missed it while I was skipping quickly through interface3.pdf
and feared that it was dropped. But, luckily, you are right, it's still documented and the example can stay as is was. Thank you.
Integrated into https://github.com/T-F-S/csvsimple/releases/tag/v2.6.1
The first argument of
\IfCsvsimIntCompareTF
and\ifcsvintcmp
is documented as<integer expression>
, but it actually has to have the form<integer expression> (<relation> <integer expression>)+
, as required by the underlying\int_compare:nTF
/\int_compare_p:n
. https://github.com/T-F-S/csvsimple/blob/94632b980ff7f5beed9ca7a1361cf05c2481ac8b/doc/latex/csvsimple/csvsimple-l3.tex#L2448-L2459The difference is, an
<integer expression>
cannot contain a relation, while the first argument of\int_compare:nTF
requires at least one relation. A relation is one of=
,==
,>=
,>
,<=
,<
, and!=
, from doc of\int_compare:nTF
.Differently,
<floating point expression>
is, from my point of view, a valid description for arguments that are finally passed to\fp_compare:nTF
/\fp_compare_p:n
, because<fp expr> (<relation> <fp expr>)+
is one possible form of<fp expr>
,<fp expr> (<relation> <fp expr>)+
evaluates to+1
if true and+0
otherwise, and\fp_compare:nTF
treats $\pm0$ asfalse
and all other values astrue
.Perhaps the last rule can be documented.