search

T-F-S / genealogytree

pedigree and genealogy tree diagrams
LaTeX Project Public License v1.3c
45 stars 7 forks source link

Integrating with genealogytree from new package #43

Open mikkelee opened 7 months ago

mikkelee commented 7 months ago

Some years ago (#24), I asked about using \gtrPrintDatabase to format vital data‡ outside family trees, and the command was subsequently documented for use.

I have finally gotten around to working on an actual package for genealogical profiles, and it's starting to take real shape. Before I send it to CTAN (at least 2-3 weeks into the future), I would like to give you an opportunity to comment, so nothing untoward "calcifies" and becomes an issue later.

As it is still somewhat fluid, there are no docs yet, but it can be seen in action in my test document below and its corresponding .tex file. The functionality is used in the first two profiles in particular, as well as a couple on the next page. https://github.com/mikkelee/latex-genprofile/blob/master/test/genprofile.pdf

The code that integrates with genealogytree is these lines: https://github.com/mikkelee/latex-genprofile/blob/f43fb66398cf46bc00dbeef30dda26dbdd9eec9e/latex/genealogy-profiles.sty#L380-L420

‡ I am not entirely pleased with the phrase "vital data" but haven't been able to find a term of art for such a list of life events (perhaps "life events", actually?).

T-F-S commented 7 months ago

I have finally gotten around to working on an actual package for genealogical profiles, and it's starting to take real shape. Before I send it to CTAN (at least 2-3 weeks into the future), I would like to give you an opportunity to comment, so nothing untoward "calcifies" and becomes an issue later.

I see nothing problematic inside the genealogytree package integration part of your code. All used internal macros should be stable for the future-to-see and, currently, I have no plans to change them.

I'm looking forward for your new package 👍

mikkelee commented 7 months ago

Thanks! I'll keep on truckin', then — and of course if anything should arise in the future that I don't notice, I'll be happy to find a solution :)

By the way, maybe it is a personal preference, but the current version of \gtr@list@event{floruit} ends up checking whether any of birth/baptism/death/burial exists before typesetting, whereas the \gpr_if_lifespan_defined: I implement in my package checks whether "a begin and an end" are defined, which I prefer (cf. also #9). Although given how latex2e if/then works, it would probably be quite a nested redundant mess to implement the same functionality that way? I never got a good handle on complex conditionals in latex2e...

T-F-S commented 7 months ago

By the way, maybe it is a personal preference, but the current version of \gtr@list@event{floruit} ends up checking whether any of birth/baptism/death/burial exists before typesetting, whereas the \gpr_if_lifespan_defined: I implement in my package checks whether "a begin and an end" are defined, which I prefer (cf. also #9). Although given how latex2e if/then works, it would probably be quite a nested redundant mess to implement the same functionality that way? I never got a good handle on complex conditionals in latex2e...

I will mark this as an enhancement. Currently, I do not have the time, but it should be possible (later).

mikkelee commented 5 months ago

And now on CTAN 🎉 :)

https://ctan.org/pkg/genealogy-profiles

T-F-S commented 5 months ago

And now on CTAN 🎉 :)

https://ctan.org/pkg/genealogy-profiles

I just looked into it. Very nice! :)

mikkelee commented 5 months ago

Thanks! =)