search

T-PLAY / hub

Central HUB and communication protocol of TPLAY
https://t-play.github.io/hub/
Mozilla Public License 2.0
2 stars 1 forks source link

Fixup cpp check #15

Closed hiergaut closed 5 months ago

hiergaut commented 5 months ago
hiergaut commented 5 months ago

I am splitting this branch to separate old server implement removing from this feature branch, please do not merge this branch until process done.

hiergaut commented 5 months ago

Splitted, waiting now for #16 merged.

hiergaut commented 5 months ago

@nmellado this PR is ready to merge

hiergaut commented 5 months ago

Not ready, some tests failed

hiergaut commented 5 months ago

tests passed, @nmellado this PR is ready to merge

nmellado commented 5 months ago

I've cleaned the history.

Question: why removing mqtt tests in this PR ?

hiergaut commented 5 months ago

this cmake line list(FILTER test_srcs EXCLUDE REGEX ".*Mqtt\\.cpp$") did the job. It removed Mqtt test if Mqtt library not found The lines I commented are useless now because I use one directory per src module We can rename the commit "Disable Mqtt tests" -> "Removed useless mqtt cmake removal"

hiergaut commented 5 months ago

Can I do the commit name change ?

hiergaut commented 5 months ago

@nmellado this PR is ready to merge