search

T-PLAY / hub

Central HUB and communication protocol of TPLAY
https://t-play.github.io/hub/
Mozilla Public License 2.0
2 stars 1 forks source link

Licensing headers with MPL 2.0 #19

Closed hiergaut closed 3 months ago

hiergaut commented 5 months ago

Licensing headers with MPL 2.0 convention

hiergaut commented 5 months ago

@nmellado ready to merge

GarzoneTTT commented 5 months ago

Template proposition for copyright headers:

/*******************************************************************************
* [list of Copyright, adding at the end of the list ]
* Copyright (c) date entity name [optional adress]
*
* All rights reserved. This program and the accompanying materials
* are made available under the terms of the Mozilla Public License, v. 2.0.
* available at https://mozilla.org/MPL/2.0/.
*
* Initial Contributors:
*     [ list of initial contributors for this file ]
*     - First name Last name [optional (entity name)]
*
* New contributors:
*     [ list of contributors that have modified this file after the initial contribution , 
*        adding at the end of the list]
*     - First name Last name [optional (entity name)]: role
*******************************************************************************/
GarzoneTTT commented 5 months ago

Here is an example:

/*******************************************************************************
* Copyright (c) 2021 IRIT, computer science research laboratory, Toulouse, France.
* https://www.irit.fr/tplay/
*
* All rights reserved. This program and the accompanying materials
* are made available under the terms of the Mozilla Public License, v. 2.0.
* available at https://mozilla.org/MPL/2.0/.
*
* Initial Contributors:
*   - Nicolas Mellado (IRIT)
*   - Gauthier Bouyjou (IRIT, Toulouse Tech Transfer) 
*******************************************************************************/
hiergaut commented 5 months ago

I use this template for all header files.

/*******************************************************************************
* Copyright (c) 2021 IRIT, computer science research laboratory, Toulouse, France.
* Please visit https://www.irit.fr/tplay/.
*
* All rights reserved. This program and the accompanying materials
* are made available under the terms of the Mozilla Public License, v. 2.0
* available at https://mozilla.org/MPL/2.0/.
*
* Initial Contributors:
*   - Nicolas Mellado (IRIT)
*   - Gauthier Bouyjou (IRIT)
*******************************************************************************/

Are you ok with this template ?

The contributors change depending of the file. For file I have created before v1.2, the contributors are me and Nicolas because of the supervision. Should I add Adrian too ? From v1.2 to v2.0 I have created some files of my own (without assistance), so I put as the only contributor myself without company After v2.0 Nicolas and me with TTT company for me. Are you ok with that things, check the modification files please.

Also, for some files, I added François as contributor too because of the support he gave me. I did'nt add Chems because I am not aware of any contributions he made, and were inspired by the François code.

Finally, If all rights for you, I will remove the script file and start the reviewing.

hiergaut commented 4 months ago

For information, this url https://www.mozilla.org/en-US/MPL/headers/ recommends "always use the appropriate license headers" to write something like this

/*
 * This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at https://mozilla.org/MPL/2.0/.
 */
hiergaut commented 4 months ago

In my first proposal, there is no reference to the hub project. Let's imagine that the file is found alone on the net, there is no way of knowing that this file belongs to the https://github.com/T-PLAY/hub project. We only know that it is part of the https://www.irit.fr/tplay/ project. To resolve the problem, we can add this line ? License: https://github.com/T-PLAY/hub/blob/main/LICENSE

hiergaut commented 4 months ago

new proposal : 

/*******************************************************************************
* Copyright (c) 2021 IRIT, computer science research laboratory, Toulouse, France.
* Please visit https://www.irit.fr/tplay/.
*
* All rights reserved. 
* This code belongs to the hub project (https://github.com/T-PLAY/hub).
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at https://mozilla.org/MPL/2.0/.
*
* Initial Contributors:
*   - Nicolas Mellado (IRIT)
*   - Gauthier Bouyjou (IRIT)
*******************************************************************************/
nmellado commented 4 months ago

new proposal :

/*******************************************************************************
* Copyright (c) 2021 IRIT, computer science research laboratory, Toulouse, France.
* Please visit https://www.irit.fr/tplay/.
*
* All rights reserved. 
* This code belongs to the hub project (https://github.com/T-PLAY/hub).
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at https://mozilla.org/MPL/2.0/.
*
* Initial Contributors:
*   - Nicolas Mellado (IRIT)
*   - Gauthier Bouyjou (IRIT)
*******************************************************************************/

Sounds good to me, maybe I would suggest a small change

* This code belongs to tplay/hub project (https://github.com/T-PLAY/hub).
hiergaut commented 4 months ago

Ready for review.

nmellado commented 4 months ago

@GarzoneTTT are you fine with this proposal ?

GarzoneTTT commented 4 months ago

@GarzoneTTT are you fine with this proposal ?

It's fine by me.