Possibility to search for all rooms

T-Systems-MMS / phonebook

A WebApp to search for people in a company. (Currently only the frontend is fully open sourced)

https://t-systems-mms.github.io/phonebook/

MIT License

19 stars 13 forks source link

Possibility to search for all rooms #217

Open mschwrdtnr opened 5 years ago

mschwrdtnr commented 5 years ago

Is your feature request related to a problem? Please describe. If you search for a room where no one sits you can't find him.

Describe the solution you'd like If you search in the searchbar for something you will get room suggestions and auto complete stuff.

You type in 223 -> you will get a suggestion like Material-autocomplete (Room Icon - Room 223) -> if you click on the suggestion you will redirect to the belonging room page.

Important things:

Angular Material Searchbar
Autocomplete (Groups)
[ ] Highlight the first solution https://material.angular.io/components/autocomplete/examples
[ ] Unit tests (a list get in, a list get out)

Google example:

mschwrdtnr commented 5 years ago

@Zeroks77 will solve this issue. If you @T-Systems-MMS/phonebook-developers have any ideas or things to say to this issue please do it this week! <3

DanielHabenicht commented 5 years ago

I would specify an out of scope sentence: do not show the results in the table (only show them as suggestion)

I think we should speak about how the search should be structured before implementing anything.

Because it might be a little bit overwhelming with future features that are all located in the search bar. What I mean is:

Where are we searching for people, org units and locations? Do we use the same search bar for everything? Should it be site specific? Are the results shown site specific or should we build a shared search result view? Because in my mind using the suggestion feature is a little bit counterintuitive as I (as a user) would expect that filter tags are suggested as I type.

Zeroks77 commented 5 years ago

As @paule96 just told me, we should use the specific sections.

In the room section we only browse for rooms and usually we browse for people and so on.

mschwrdtnr commented 5 years ago

If you want specific search bars: We need to visualize that the searchbar have changed on different sites.

A way with one searchbar can be:

One searchbar for everything (like now)
Small Settings Button on the right side with options to change the search results
- Settings: checkboxes for different options (All checked options will be suggested) -> Rooms, OrgUnits, People, Location,... (but not tooooo much)
Another way: The options People, Rooms, OrgUnit stand under the searchbar with chips and can be toggled on and off.
The named options should not affect the search results but the suggestions.

While i wrote i also can image that the site specific search can be cool:

You are on the rooms page: Searchbar is changing to "Search for a specific room"
You are on the organi page: Searchbar is changing to "Search for a OrgUnit or a Person in the Organigram"
A small information that you only search for ... and a link to redirect to the "Main Search"

Zeroks77 commented 5 years ago

When I was just talking to a colleague, I simply asked him what he thought was better...

I think when we talk to some other colleagues it becomes clearer, but he was in favour of being able to search for rooms in the room page and would not like to have to edit the search bar via checkboxes or something like that...

mschwrdtnr commented 5 years ago

I don't really like the way to just talk to a some people in one department. I also can imagine that the asked people aren't the persons who often use the phonebook and also have more technical expertise than other colleagues in e.g. HR department.

But yes, i also think that the option with one searchbar can a bit too much for the simple users and we should use specific site searchbars.

DanielHabenicht commented 5 years ago

@Zeroks77 talk to as many as you can. It's always a good idea. Just keep @mschwrdtnr sentence in your mind :)

If we use different search bars the question arises what the dashboard search bar does. ;)

Zeroks77 commented 5 years ago

but if you consider the dashboard search bar as the "main search bar" for people, it would serve a purpose

DanielHabenicht commented 5 years ago

That's not what I meant, I meant that it would either search for all (people, room, org) or there should be non, there has to be a switch or it just searches for people. In either way, the search action taken has to be clear to the user.

Zeroks77 commented 5 years ago

ohhh k ...

this could be very defficult i imagine :/