T-Systems-MMS / phonebook

A WebApp to search for people in a company. (Currently only the frontend is fully open sourced)
https://t-systems-mms.github.io/phonebook/
MIT License
18 stars 13 forks source link

Take dialogues to the same level #411

Open Zeroks77 opened 4 years ago

Zeroks77 commented 4 years ago

Make dialogues uniform. Since there were different opinions in #382, we should clarify how we want to design the dialogs.

Alignment of the texts: left Blur: yes Backdrop Closing: yes, if changes are saved automatically Button position:

Too Consider:

mschwrdtnr commented 4 years ago

I am not sure if this is possible but i think we can build a component template (or something like in angular) for all dialogs do ensure they have not only the same style but also the same layout.

My preference for the mentioned things: Alignment of text: left --> centered text is not good to read Button position: right corner Backdrop closing: Yes. Blur: Yes but not too much.

Other things:

DanielHabenicht commented 4 years ago

We should search for current implementations (hasBackdrop:) and check if they are still needed.

mschwrdtnr commented 4 years ago

We should search for current implementations (hasBackdrop:) and check if they are still needed.

I would say that it's needed. Ether we don't allow to click behind the dialog or we use "hasBackdrop". The behavior that you can navigate while a dialog is open is very confusing and looks every time like a bug for me. Or not?

DanielHabenicht commented 4 years ago

I meant "while implementing this solution we should look for already written code, consolidate it and remove duplicated lines" This had nothing to do with the meaning of this issue, just with its implementation

Zeroks77 commented 4 years ago

hey guys, just noticed that atm in my dev enviroment all dialogs have a backdrop Oo.

DanielHabenicht commented 4 years ago

Which branch?

Zeroks77 commented 4 years ago

my button branch