Open Zeroks77 opened 4 years ago
I am not sure if this is possible but i think we can build a component template (or something like in angular) for all dialogs do ensure they have not only the same style but also the same layout.
My preference for the mentioned things: Alignment of text: left --> centered text is not good to read Button position: right corner Backdrop closing: Yes. Blur: Yes but not too much.
Other things:
We should search for current implementations (hasBackdrop:
) and check if they are still needed.
We should search for current implementations (
hasBackdrop:
) and check if they are still needed.
I would say that it's needed. Ether we don't allow to click behind the dialog or we use "hasBackdrop". The behavior that you can navigate while a dialog is open is very confusing and looks every time like a bug for me. Or not?
I meant "while implementing this solution we should look for already written code, consolidate it and remove duplicated lines" This had nothing to do with the meaning of this issue, just with its implementation
hey guys, just noticed that atm in my dev enviroment all dialogs have a backdrop Oo.
Which branch?
my button branch
Make dialogues uniform. Since there were different opinions in #382, we should clarify how we want to design the dialogs.
Alignment of the texts: left Blur: yes Backdrop Closing: yes, if changes are saved automatically Button position:
Too Consider: