T-Systems-MMS / phonebook

A WebApp to search for people in a company. (Currently only the frontend is fully open sourced)
https://t-systems-mms.github.io/phonebook/
MIT License
19 stars 13 forks source link

Use automated code quality / code review app #433

Open mschwrdtnr opened 4 years ago

mschwrdtnr commented 4 years ago

Is your feature request related to a problem? Please describe. With increasing number of members we can get the problem, that some formatting-stuff and other things aren't right. Because our standards are not well documented or people don't seriously read the documentation we can run into problems where we need to say the same things many times: "No, you need to make it like this", "you need to use prettier" or other things.

Describe the solution you'd like I suggest to use a github-app which automatically checks for some known and often done issues.

There are many apps for this: https://github.com/marketplace?category=code-quality&type=apps https://github.com/marketplace?category=code-review&type=apps

This looks like a small and good solution but i also don't know how effective it will be: https://github.com/marketplace/hound/plan/MDIyOk1hcmtldHBsYWNlTGlzdGluZ1BsYW4xMDYx#pricing-and-setup

Let me know what you think about. I think that this will help us being more effective.

DanielHabenicht commented 4 years ago

Unfortunately, Hound does not offer linting for typescript and HTML.

DanielHabenicht commented 4 years ago

https://restyled.io/

DanielHabenicht commented 4 years ago

@jandd can you add restyled to this repo? I tried it out and it works :)

jandd commented 4 years ago

@DanielHabenicht I setup restyled for this repository

DanielHabenicht commented 4 years ago

Thanks!