search

T-Systems-MMS / phonebook

A WebApp to search for people in a company. (Currently only the frontend is fully open sourced)
https://t-systems-mms.github.io/phonebook/
MIT License
19 stars 13 forks source link

No info dialog for IE users #445

Open mschwrdtnr opened 4 years ago

mschwrdtnr commented 4 years ago

Describe the bug: If people open the phonebook in IE they will don't see anything. image

Console: image

To Reproduce: Open demo-phonebook.me.

Expected behavior: There should be an info that IE is not supported. The dialog exists but don't show.

--> There is an option in IE where you can easy open the site in edge ( STRG+Shift+E). A button to open the site in another browser would be cool.

Additional context: IE 11.864.17763.0

DanielHabenicht commented 4 years ago

Possible solution: Display the dialog before using UrlSearchParams, or conditionally check if IE is used before accessing it.

DanielHabenicht commented 4 years ago

We should display this dialog without the need to load angular, thus we can drop everything that we currently need to be compliant with IE.

VanLampe commented 4 years ago

@DanielHabenicht so I will put clean JS code in an extra file, wich will be loaded before angular?

DanielHabenicht commented 4 years ago

Well you can also use the statement HTML feature of IE

https://docs.microsoft.com/en-us/previous-versions/windows/internet-explorer/ie-developer/compatibility/ms537512(v=vs.85)?redirectedfrom=MSDN

And add it to the index.html

VanLampe commented 4 years ago

I guess that wont work in "newer" Versions of IE: https://docs.microsoft.com/en-us/previous-versions/windows/internet-explorer/ie-developer/compatibility/hh801214(v=vs.85)?redirectedfrom=MSDN

DanielHabenicht commented 4 years ago

Ok, dann einfach ein Javascript Snippet nutzen und am besten unten in der index.html anfügen.

mschwrdtnr commented 4 years ago

accidentally closed @DanielHabenicht ?

DanielHabenicht commented 4 years ago

Seems so, the new GitHub app does not have colored buttons.

mschwrdtnr commented 4 years ago

@FrankLambrette if you're implementing the feature maybe you can try to implement this, if it's easy.. "--> There is an option in IE where you can easy open the site in edge ( STRG+Shift+E). A button to open the site in another browser would be cool."

VanLampe commented 4 years ago

@DanielHabenicht @mschwrdtnr , after two month no i have some time to implement it. Just a question: how do I import a plain js script in the index.html? Angular Docu says I should put it in the angular.json scripts section. But we need to load the script before angular is loaded. If I try to import it via Githubissues.

  • Githubissues is a development platform for aggregating issues.