search

T-Systems-MMS / phonebook

A WebApp to search for people in a company. (Currently only the frontend is fully open sourced)
https://t-systems-mms.github.io/phonebook/
MIT License
18 stars 13 forks source link

Image does not reload in chrome #792

Open DanielHabenicht opened 3 years ago

DanielHabenicht commented 3 years ago

Describe the bug:

Somebody, ~cough @Zeroks77 cough implemented a great april pun but neglected that the random variable is important :)~ Nevermind, I read the if statement the other way around, so something does not seem to work.

To Reproduce:

  1. Upload a picture in chrome
  2. The picture does not change because it still gets cached.

Expected behavior:

Additional context:

https://github.com/T-Systems-MMS/phonebook/blob/0a68f53373168c6fdd3d56b17daf155a34654728/Phonebook.Frontend/src/app/modules/profile-picture/components/profile-picture/profile-picture.component.ts#L59-L60

The random reload feature is disabled because it only gets enabled with the feature flag on. Either we should find a way to make both work or remove the feature flag.