T-Wan-Lin / pe

0 stars 0 forks source link

Lack of list confirmed command #7

Open T-Wan-Lin opened 1 year ago

T-Wan-Lin commented 1 year ago

Screenshot 2023-04-14 at 4.55.44 PM.png

If a user has a long list of companies, it would be very helpful to be able to list out all companies that have confirmed their attendance rather than just those that have not confirmed. This is because you have a confirm and unconfirm command which gives due consideration that a company may pull out at the last minute. Being able to have the opposite of list unconfirmed would be very helpful, rather than having to trawl through the whole list with the list companies command. The omission of such a command is strange.

nus-se-bot commented 1 year ago

Team's Response

We did not think that list confirmed was needed considering the use case. The main purpose of the confirm/unconfirmed was to let the user chase the companies who have yet to confirm their attendance. Before the event, there would not be any need for a list confirm function since the user can simply delete the companies who are not attending, and when the event starts there should not be any companies who have yet to confirm their attendance.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: The user stories in the developer guide say otherwise:

Screenshot 2023-04-19 at 9.17.15 AM.png Screenshot 2023-04-19 at 9.16.55 AM.png

Due to the lack of time during the testing phase, I was not able to read the developer guide properly but now after due consideration, it seems even more baffling that you would omit a crucial command which has been planned for in v1.0 and v2.0. As an event planner, I do agree that a list unconfirmed command is important for follow-up action but what about a list of confirmed attendees? I believe that such a command to essentially filter by confirmed attendance is important for an event planner to ensure that the venue size is appropriate for the number of companies attending the event. The user would have to actually manually look through the list, which contradicts your user stories.


## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.High`] - [x] I disagree **Reason for disagreement:** **Without** this command, I believe this is how a typical user experience would go: 1. Companies A, B, C, D, and E are added to the existing list of 70 companies as potential attendees of the `Career Fair for CDE` event. 2. Company A, D, and E confirm their attendance. The event planner marks them as confirmed. 3. Due to last-minute circumstances, Company E and A pulled out of the event. 30 other companies also confirm their attendance 4. To obtain a basic record of who is attending the event, the event planner would have to manually scroll through the list to find out who is confirmed OR the event planner uses the `list unconfirmed` command and do some subtraction from the main list of companies with the `list companies` command. This would be incredibly inconvenient and therefore I believe there should be an opposite to the command `list unconfirmed`, like how the application has naturally opposing commands like `confirm` and `unconfirm`, `add` and `delete`/`purge`.