search

T-vK / ESP32-BLE-Keyboard

Bluetooth LE Keyboard library for the ESP32 (Arduino IDE compatible)
2.27k stars 378 forks source link

ReleaseAll does not release MediaKeys #289

Open muddyfeet opened 3 months ago

muddyfeet commented 3 months ago

In BleKeyboard.cpp from line 459:

void BleKeyboard::releaseAll(void) { _keyReport.keys[0] = 0; _keyReport.keys[1] = 0; _keyReport.keys[2] = 0; _keyReport.keys[3] = 0; _keyReport.keys[4] = 0; _keyReport.keys[5] = 0; _keyReport.modifiers = 0; _mediaKeyReport[0] = 0; _mediaKeyReport[1] = 0; sendReport(&_keyReport); }

Does not send _mediaKeyReport[0] and [1]. Suggest the code is changed to:

void BleKeyboard::releaseAll(void) { _keyReport.keys[0] = 0; _keyReport.keys[1] = 0; _keyReport.keys[2] = 0; _keyReport.keys[3] = 0; _keyReport.keys[4] = 0; _keyReport.keys[5] = 0; _keyReport.modifiers = 0; _mediaKeyReport[0] = 0; _mediaKeyReport[1] = 0; sendReport(&_keyReport); sendReport(&_mediaKeyReport); }

Have raised PR #290 to fix