Open kaitvan opened 2 years ago
Thanks for getting to these changes quickly! I know they seem like small things, but I would love for you to have really solid syntax habits from Mod 0, so that you can focus on concepts in Mod 1. I now feel confident that you have a solid understanding of Ruby syntax, data types, and how to model data using hashes. You are officially technical ready
. Keep up the hard work moving forward and let me know if you have any questions. As mentioned on the Mod 0 site, we will be reviewing your Mod 1 Prework to determine promotion to Mod 1 - finish strong!
Hi TJ, I finished reviewing your assessment and there is one change that I’d like for you to make before we consider you technical ready. Please have them done by EOD Monday and send me a slack message once completed!
JUST FYI -- no need to make these changes. This feedback is only for your learning.
model_a.rb
. Inmodel_b.rb
, you did a good job naming the variables for your booleans by usingis_lifted
andhas_flames
-- these have a clear true or false value. Inmodel_a.rb
, you haveplanes_available
anddelayed_flights
-- these are unclear if they should have a numerical value or a boolean value. You could make it better by changing the variable names to something likehas_planes_available
andhas_delayed_flights
.MUST BE CHANGED
model_a.rb
, use all lowercase letters and snake_case, just like you would for any other variable.Send me a DM on Slack when you've completed these changes! Thank you.