T0biasCZe / AdbFileManager

Fast Android <-> Windows file manager using ADB protocol
444 stars 29 forks source link

Files still keep copyin after closing the program[BUG] #4

Open MrKrota opened 11 months ago

MrKrota commented 11 months ago

Describe the bug I tried to copy 1019 files (Around 12GB) from my phone (A Galaxy S21) to my PC (A fairly powerful Windows Machine) but I noticed that the program appear to be frozen, so I tried to close it, and after I did that I noticed that the files keep being copied to my PC from my Phone even If I terminated the process from task manager.

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context CPU Usage never passed 10% usage, and the HDD I use to store media files only faced a 40% aprox of usage (only being used to copy those files as I don't use it for anything else). Other components usage was really low.

T0biasCZe commented 11 months ago

When you click the cross, you aren't closing the program, you are only closing the GUI. So the function that copies the files keeps running until it finishes and then the program completes When you kill it with taskmanager, it may stop the program, but the current CMD process that does the actual copying will continue running (and if you are copying whole folder, the whole copy will continue, if you multi select copy, then it will finish only the current file) Also, you may be limited by USB speed, that's why CPU and HDD aren't maxed out (and copying files also isn't that demanding to CPU...)

Dne čt 27. 7. 2023 7:51 uživatel Carlos Caldelas @.***> napsal:

Describe the bug I tried to copy 1019 files (Around 12GB) from my phone (A Galaxy S21) to my PC (A fairly powerful Windows Machine) but I noticed that the program appear to be frozen, so I tried to close it, and after I did that I noticed that the files keep being copied to my PC from my Phone even If I terminated the process from task manager.

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Windows
  • RAM: 32 GB
  • Processor: Ryzen 5600X

Additional context CPU Usage never passed 10% usage, and the HDD I use to store media files only faced a 40% aprox of usage (only being used to copy those files as I don't use it for anything else). Other components usage was really low.

— Reply to this email directly, view it on GitHub https://github.com/T0biasCZe/AdbFileManager/issues/4, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKTWPBSKLWCPT2EPQIHEB43XSH6WFANCNFSM6AAAAAA2ZRYVZQ . You are receiving this because you were assigned.Message ID: @.***>

T0biasCZe commented 11 months ago

Though I will add that when you close the program, it will finish only 1 current file and then make it stop and close

MrKrota commented 11 months ago

Thanks for your answer!. And yeah!, that last thing you mentions sounds good, leaving the process running in background even after closing the GUI can lead to really bad scenarios and user experience.

T0biasCZe commented 11 months ago

On the other hand, forcefully closing the process when closing GUI may result in half copied corrupted file And when copying whole folder, it will finish copying the whole folder... Because it is as 1 copy operation