T3Voila / templavoilaplus

TYPO3 Extension TemplaVoilà! Plus for TYPO3 8/9/10/11/12 LTS
https://extensions.typo3.org/extension/templavoilaplus/
GNU General Public License v2.0
26 stars 27 forks source link

UX: modal should not close on ESC or outside mouse click if edits took place #501

Open jpmschuler opened 1 year ago

jpmschuler commented 1 year ago

A modal edit form (TVP page module, edit page or edit content) should not close on keyboard ESC or outside mouse click if there are changes to the content.

So an ESC or outside click shouldn't just remove the modal, but rather "click the close button" in order to show the warning dialog about pending changes.

jpmschuler commented 4 months ago

If anybody could contribute an idea to this, I'd gladly write the patch. I looked into it repeatedly and can't figure out why it is that way in the first place, as the docs suggest it shouldn't be -.-

A simple hotfix to just prevent ESC/outside-click would be sufficient IMHO, an intelligent signal to the close button to "sometimes" close it would be just nice to have IMHO.