During 12LTS migration an EXT:cal upgrade wizard failed because FlexFormTools8::cleanFlexFormXML_callBackFunction() created an exception.
After applying the migration path from https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/11.5/Deprecation-95254-TwoFlexFormToolsMethods.html to fix that exception the further calls relied on an $pObj->traverseFlexFormXMLData_Data which I couldn't resolve to anything. So probably as of time of writing this was always null and probably thus nothing much was done in that if. The remainder of the function is from the base function, so I propose to just delete it.
While that resolves my updater issues, I don't have enough insight to prove that there are no race conditions from this, so please check this
¯\_(ツ)_/¯
During 12LTS migration an EXT:cal upgrade wizard failed because FlexFormTools8::cleanFlexFormXML_callBackFunction() created an exception.
After applying the migration path from https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/11.5/Deprecation-95254-TwoFlexFormToolsMethods.html to fix that exception the further calls relied on an
$pObj->traverseFlexFormXMLData_Datawhich I couldn't resolve to anything. So probably as of time of writing this was always null and probably thus nothing much was done in thatif. The remainder of the function is from the base function, so I propose to just delete it.While that resolves my updater issues, I don't have enough insight to prove that there are no race conditions from this, so please check this ¯\_(ツ)_/¯