Upgrading the project to the new format

T4MVC / R4MVC

R4MVC is a Roslyn code generator for ASP.NET Core MVC apps that creates strongly typed helpers that eliminate the use of literal strings in many places

Apache License 2.0

157 stars 48 forks source link

Upgrading the project to the new format #43

Closed artiomchi closed 7 years ago

artiomchi commented 7 years ago

Upgrading the project from the legacy .xproj format to the new .csproj project format, and the project runtime from dnx to .NET Standard and .NET Core

Since a number of classes have been removed (like the Roslyn's ICompileModule) some code has been temporarily commented out. I've also taken the liberty of recreating the Host app from scratch with a new project template, since the one currently there is very outdated, and was not worth manually updating.

artiomchi commented 7 years ago

I've not touched build.cmd and makefile.shade (since I don't know your AppVeyor config), and the unit tests will fail because of this line

artiomchi commented 7 years ago

Based on one of my projects in AppVeyor, I mocked up something like this as a basic start:

dotnet --info
appveyor-retry dotnet restore -v Minimal

dotnet build "src\R4Mvc"
dotnet build "src\R4MvcHostApp"
dotnet build "src\R4Mvc.Test"

cd test\R4Mvc.Test
dotnet test

kevinkuszyk commented 7 years ago

Thanks for this. All looks good to me. We have the build.cmd because AppVeyor has having trouble building .net core apps early on. I'll switch it back to build the solution.

To be honest, I don't recall why we have the makefile.shade. I'll also ignore those tests for now.