search

T8RIN / ImageToolbox

🖼️ Image Toolbox is a powerful app for advanced image manipulation. It offers dozens of features, from basic tools like crop and draw to filters, OCR, and a wide range of image processing options
Apache License 2.0
3.59k stars 172 forks source link

Overwrite Files setting resets Image picker, but not the other way #1226

Closed k-dx closed 2 months ago

k-dx commented 2 months ago

Describe the bug If I understand correctly, the Overwrite Files setting only works if Image source is set to Gallery. When I toggle Overwrite Files, it changes it Image source to Gallery. However when I change Image source to something other than Gallery Overwrite Files stays on, when it should get changed to off.

To Reproduce

  1. Set Overwrite Files to on.
  2. When changing the Image source setting the Overwrite Files stays on.

Expected behavior Changing Image source should set Overwrite Files to off if chosen settings are incompatible and should tell user that Overwrite Files has been changed.

Screenshots obraz obraz

Smartphone (please complete the following information):

T8RIN commented 2 months ago

It works for all except camera and photo picker

T8RIN commented 2 months ago

if you try to overwrite and it fails, then toast with message that you should repick and source are set to needed one

T8RIN commented 2 months ago

not a bug in my opinion

k-dx commented 2 months ago

Why not inform user settings were changed? It's confusing