T8RIN / ImageToolbox

🖼️ Image Toolbox is an powerful picture editor, which can crop, apply filters, add some drawing, erase background, edit EXIF or even create PDF file
Apache License 2.0
3.28k stars 153 forks source link

Styles #634

Closed devSJR closed 7 months ago

devSJR commented 8 months ago

This tool has a lot of filters. I was wondering if there are presets of filter chains like in imagepipe or snapseed. If this is not present in imagetoolbox it might be a nice addition in the future.

T8RIN commented 8 months ago

I can add this, vut i don't know which filters i should yse to achieve effects on the picture, you can provide it, if you can

devSJR commented 8 months ago

Thanks for the fast response. I made a mistake. Imagepipe is not able to apply filters. I confused it with another tool. Photo Editor (Kotlin, MIT licence, https://github.com/burhanrashid52/PhotoEditor) has filters. Here is a link to the code likely doing the filtering or that uses a library for this.

https://github.com/burhanrashid52/PhotoEditor/blob/e3a91a683522f5c4fb2380e0376f8c246c83f01a/photoeditor/src/main/java/ja/burhanrashid52/photoeditor/PhotoFilter.kt https://github.com/burhanrashid52/PhotoEditor/blob/e3a91a683522f5c4fb2380e0376f8c246c83f01a/app/src/main/java/com/burhanrashid52/photoediting/filters/FilterViewAdapter.kt https://github.com/burhanrashid52/PhotoEditor/blob/e3a91a683522f5c4fb2380e0376f8c246c83f01a/photoeditor/src/main/java/ja/burhanrashid52/photoeditor/ImageFilterView.kt

https://github.com/burhanrashid52/PhotoEditor/blob/master/photoeditor/src/main/java/ja/burhanrashid52/photoeditor/ImageFilterView.kt

PixelDroid (Kotlin, GPL 3, https://github.com/H-PixelDroid/PixelDroid) also seems to have filters. The nice thing about this is that it's possible to alter the brightness, contrast and saturation once a filter is applied to an image. But maybe this is an independent function. However, I was not able to locate a library that is likely responsible to filter images. Maybe you are more lucky than me.

T8RIN commented 8 months ago

No, i don't need such libraries, i just want you to combine my app existing filters to create some presets :) if i add that i would also add ability to create custom presets

devSJR commented 8 months ago

Yes, that is of course correct. It was my assumption that you can do exactly that with the existing ~ 60 filters. I had searched online for cookbooks that describe something like this, but unfortunately, it was not very successful. That's why the question came up whether you can use existing libraries to do something like this with fast presets. In the end, the filters could still be processed with the existing filters. I have tried different things, but the creation of the vignette effect, for example, actually from everything else, I have not been able to do it. In the end, this is exactly what happened to my initial request.

T8RIN commented 8 months ago

Vignette works pretty well, can you then tell some names of presets you want to exist initially?

devSJR commented 8 months ago

Sorry, for the confusion. I didn't mean that the Vignette effect in ImageToolbox does not work. It works very well. My apologies. I need to be more precise with comments. What I want to say is that I cannot tell you how others do that. It appears that there are typical image processing workflows to get filters like “oil painting”, “Fine art”, “Accentuate”, “Posh”, “Grunsh”, “Vintage”, “Faded Glow”, “Silhouette” … “Morning”. For example, “Morning” from Snapseed seems to add a gradient of a yellowish tone (bottom) to transparent (top) as double exposure. I looked on the internet and there are just numerous apps doing that. But they don't disclose how they do it exactly. Maybe in future, somebody with more artistic insight will be able to answer this. Thanks for considering it!

T8RIN commented 8 months ago

Okay thanks for the idea

devSJR commented 7 months ago

The latest commits (entering 2.6.1 alpha) exceed by far my enhancement request. Well done!

T8RIN commented 7 months ago

I also added a small preview at the start of each filter to easily understand the approximate effectđź‘€

T8RIN commented 7 months ago

Alpha 02 will contain more than 44 predefined filters with no arguments

T8RIN commented 7 months ago

So, i think this can be closed

devSJR commented 7 months ago

The previews are great and very useful. This is definitely closed!