search

T8RIN / ImageToolbox

🖼️ Image Toolbox is an powerful picture editor, which can crop, apply filters, add some drawing, erase background, edit EXIF or even create PDF file
Apache License 2.0
3.42k stars 164 forks source link

jxl problems #893

Closed JackDropHammer closed 5 months ago

JackDropHammer commented 6 months ago

Describe the bug So, it seems like the jxl decoder is brokern, not the encoder but the decoder. If you convert an image to jxl (lossy/lossless) it comes out correct(checked by using a browser) but the preview is simply incorrect (horrible quality with tons of artifact). If you try viewing the image in the app the same problem occurs. Comparison here; Screenshot-2024-03-18-21-08-24-090-ru-tech-imageresizershrinker-1.jpg (full size image:- https://postimg.cc/1fKMBZsq)

It doesn't end there because if you convert from jxl to any other format, the image will look the same as in preview. So the image will become horrible.

This same problem seems to present in avif. (full size image :- https://postimg.cc/5jzsHR0Z) Screenshot-2024-03-18-21-20-08-568-ru-tech-imageresizershrinker-1.jpg

EDIT:- I haven't tested any of this in programs like imagemagick(sorry) To Reproduce Same as above

Expected behavior Normal images, same as they entered

Screenshots Given above

Smartphone (please complete the following information):

kremzli commented 6 months ago

Can reproduce with jxl on version 2.7.1-beta01-foss(128). Images are encoded properly but decoding shows wrong colors, the quality is the same, converting jxl image (from ImageToolbox / jxl-coder) to png does not show the wrongly decoded result

Cannot reproduce with avif

What version are you on?

T8RIN commented 6 months ago

Maybe it's fixed in jxl coder 2.1.6

T8RIN commented 6 months ago

I'll close for now, wainting for updates

kremzli commented 6 months ago

i think this is the fix https://github.com/awxkee/jxl-coder/releases/tag/2.1.8

T8RIN commented 6 months ago

Maybe, btw i updated to this version now

kremzli commented 5 months ago

my first comment is still happening (with 2.7.1 beta 2)

T8RIN commented 5 months ago

Anyways that's not handled by me

kremzli commented 5 months ago

Cannot reproduce outside of ImageToolbox https://github.com/awxkee/jxl-coder/issues/16

jonnyawsom3 commented 5 months ago

May be fixed now by b1d18ba

T8RIN commented 5 months ago

Check out the latest build, it should be solved

JackDropHammer commented 5 months ago

Check out the latest build, it should be solved

Does indeed seems to be fixed, thank you very much!

OkyDooky commented 2 months ago

I don't quite have the color issue, but the preview in "compare" (on the right siide of the slider) shows what looks like a noticeably lower resolution version with tons of aliasing. I just started using the app, so I can't compare it to before previous fixes to this issue to see if it's the same. I don't want to necro if it's not necessary.