big mistake reversed high and low bands of bollinger

TA-Lib / ta-lib-python

Python wrapper for TA-Lib (http://ta-lib.org/).

http://ta-lib.github.io/ta-lib-python

Other

9.46k stars 1.74k forks source link

big mistake reversed high and low bands of bollinger #518

Closed mablue closed 2 years ago

mablue commented 2 years ago

df['bbl'], df['bbm'], df['bbh'] = tal.BBANDS(df['real'].values, timeperiod=period, nbdevup=2.0)

0.7621999035621772
1.4082029042146873
2.0542059048671977

mrjbq7 commented 2 years ago

I would also comment, since this library is used a lot of places, switching the arguments will break a bunch of code... I could maybe see adding a BBANDS2 or something, but I guess my preference is to leave it matching the C library as close as possible...

mablue commented 2 years ago

Wraping have his own problems for example if you dont want to break rules of C version you never will have hull moving average ichimoku hakinashi renko and etc!